This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Allow hiding custom login UI even if an htpasswd file is provided. #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
great idea |
jehiah
added a commit
that referenced
this pull request
Dec 9, 2014
Allow hiding custom login UI even if an htpasswd file is provided.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a few apps behind the
google_auth_proxythat are configured to use anhtpasswdfile for API access. Folks on the team have found the login UI confusing because thehtpasswdwe're providing is only for API access, but providing anhtpasswdfile causes the login UI to display a username / password form along with the "Login with Google" button.This PR adds a flag called
display-htpasswd-form. It defaults totrueso that the current behavior remains the same. If the flag is set to false, the username / password fields on the login page will not be displayed even if an htpasswd file is provided.Let me know if this is something you're interested in pulling in.