This repository has been archived by the owner on Jan 24, 2019. It is now read-only.
Support for multi white listed urls with regex url match. #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -299,6 +302,14 @@ func (p *OauthProxy) ServeHTTP(rw http.ResponseWriter, req *http.Request) { | |||
| return | |||
| } | |||
|
|
|||
| for _, u := range p.whiteListedUrls { | |||
| match, _ := regexp.MatchString(u, req.URL.Path) | |||
| if (req.URL.Path == u) || match { | |||
There was a problem hiding this comment.
Let's make this always perform a regex match so it's easier to reason about what's matched, and move the regex compilation outside of the request loop so we can give error feedback if invalid regex's are compiled sooner (ie: at startup).
There was a problem hiding this comment.
Modified code to always perform regex match only. Also added error handling for regex match. Please have a look at updated branch.
|
Changes look great. Can you squash down to a single commit before i merge this? |
vishnuchilamakuru
force-pushed
the
master
branch
from
a898057
to
6acd98a
Compare
|
Hi Jehiah, |
vishnuchilamakuru
force-pushed
the
master
branch
from
6acd98a
to
bd2f5a7
Compare
vishnuchilamakuru
force-pushed
the
master
branch
from
bd2f5a7
to
c4d25d2
Compare
jehiah
added a commit
that referenced
this pull request
Jan 12, 2015
Support for multi white listed urls with regex url match.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sample Command to run multi whitelisted urls with regex.
./google_auth_proxy
--redirect-url="http://yourcallbackurl.com/oauth2/callback"
--google-apps-domain="yourdomain.com"
--upstream=http://127.0.0.1:8080
--cookie-secret="nuts"
--client-id="your client id"
--client-secret="your client secret"
--cookie-expire=0h30m0s
--cookie-https-only=false
--skip-auth-regex="/hello.php","/status.php","/health-check-url/*"