FeralfileExhibitionV5 contract to support ERC1155 #32
Conversation
jollyjoker992
changed the title
jollyjoker992
requested review from
lpopo0856 and
tienngovan
and removed request for
lpopo0856
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit
solhint
contracts/FeralfileArtworkV5.sol|141 col 13| Error message for require is too long: 46 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|141 col 13| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|147 col 13| Error message for require is too long: 41 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|147 col 13| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|151 col 13| Error message for require is too long: 41 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|151 col 13| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|230 col 9| Error message for require is too long: 45 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|230 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|247 col 9| Error message for require is too long: 36 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|247 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|254 col 9| Error message for require is too long: 52 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|254 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|269 col 9| Error message for require is too long: 52 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|269 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|273 col 9| Error message for require is too long: 51 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|273 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|277 col 9| Error message for require is too long: 46 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|277 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|287 col 9| Error message for require is too long: 52 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|287 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|291 col 9| Error message for require is too long: 50 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|291 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|299 col 9| Error message for require is too long: 37 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|299 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|300 col 9| Error message for require is too long: 52 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|300 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|304 col 9| Error message for require is too long: 51 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|304 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|341 col 9| Error message for require is too long: 42 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|341 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|345 col 9| Error message for require is too long: 41 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|345 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|349 col 9| Error message for require is too long: 52 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|349 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|353 col 9| Error message for require is too long: 51 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|353 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|379 col 9| Error message for require is too long: 42 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|379 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|380 col 9| Error message for require is too long: 41 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|380 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|389 col 15| Error message for require is too long: 45 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|389 col 15| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|398 col 9| Error message for require is too long: 40 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|398 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|414 col 13| Error message for require is too long: 39 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|414 col 13| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|457 col 9| Error message for require is too long: 44 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|457 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|541 col 9| Error message for require is too long: 53 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|541 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|561 col 9| Error message for require is too long: 39 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|561 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|562 col 9| Error message for require is too long: 37 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|562 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|571 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|582 col 9| Error message for require is too long: 54 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|582 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|595 col 13| Error message for require is too long: 53 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|595 col 13| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|625 col 9| Error message for require is too long: 44 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|625 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|636 col 9| Error message for require is too long: 39 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|636 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|637 col 9| Error message for require is too long: 37 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|637 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|638 col 9| Error message for require is too long: 43 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|638 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|644 col 9| Error message for require is too long: 44 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|644 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|673 col 9| Error message for require is too long: 60 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|673 col 9| Use Custom Errors instead of require statements
contracts/FeralfileArtworkV5.sol|686 col 9| Error message for require is too long: 53 counted / 32 allowed
contracts/FeralfileArtworkV5.sol|686 col 9| Use Custom Errors instead of require statements
contracts/FeralfileEnglishAuction.sol|7| global import of path ./FeralfileSaleDataV2.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/FeralfileSaleDataV2.sol|24 col 9| Error message for require is too long: 36 counted / 32 allowed
contracts/FeralfileSaleDataV2.sol|24 col 9| Use Custom Errors instead of require statements
contracts/FeralfileSaleDataV2.sol|28 col 9| Error message for require is too long: 61 counted / 32 allowed
contracts/FeralfileSaleDataV2.sol|28 col 9| Use Custom Errors instead of require statements
contracts/FeralfileSaleDataV2.sol|32 col 9| Error message for require is too long: 34 counted / 32 allowed
contracts/FeralfileSaleDataV2.sol|32 col 9| Use Custom Errors instead of require statements
contracts/FeralfileVaultV2.sol|4| global import of path @openzeppelin/contracts/access/Ownable.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/FeralfileVaultV2.sol|6| global import of path ./FeralfileSaleDataV2.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/FeralfileVaultV2.sol|8| global import of path ./ECDSASigner.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
contracts/FeralfileVaultV2.sol|26 col 5| Explicitly mark visibility in function (Set ignoreConstructors to true if using solidity >=0.7.0)
contracts/FeralfileVaultV2.sol|39 col 9| Use Custom Errors instead of require statements
contracts/FeralfileVaultV2.sol|43 col 9| Error message for require is too long: 36 counted / 32 allowed
contracts/FeralfileVaultV2.sol|43 col 9| Use Custom Errors instead of require statements
contracts/FeralfileVaultV2.sol|53 col 9| Use Custom Errors instead of require statements
contracts/FeralfileVaultV2.sol|54 col 9| Error message for require is too long: 33 counted / 32 allowed
contracts/FeralfileVaultV2.sol|54 col 9| Use Custom Errors instead of require statements
contracts/FeralfileVaultV2.sol|63 col 9| Error message for require is too long: 36 counted / 32 allowed
contracts/FeralfileVaultV2.sol|63 col 9| Use Custom Errors instead of require statements
| @@ -9,7 +9,7 @@ contract Authorizable is Ownable { | |||
| constructor() {} | |||
|
|
|||
| modifier onlyAuthorized() { | |||
| require(trustees[msg.sender] || msg.sender == owner()); | |||
| require(trustees[_msgSender()] ||_msgSender() == owner()); | |||
There was a problem hiding this comment.
Provide an error message for require
| @@ -9,7 +9,7 @@ | |||
| constructor() {} | |||
|
|
|||
| modifier onlyAuthorized() { | |||
| require(trustees[msg.sender] || msg.sender == owner()); | |||
| require(trustees[_msgSender()] ||_msgSender() == owner()); | |||
There was a problem hiding this comment.
Use Custom Errors instead of require statements
| // SPDX-License-Identifier: MIT | ||
| pragma solidity ^0.8.13; | ||
|
|
||
| import "@openzeppelin/contracts/token/ERC1155/ERC1155.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/token/ERC1155/ERC1155.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
| pragma solidity ^0.8.13; | ||
|
|
||
| import "@openzeppelin/contracts/token/ERC1155/ERC1155.sol"; | ||
| import "@openzeppelin/contracts/utils/Strings.sol"; |
There was a problem hiding this comment.
global import of path @openzeppelin/contracts/utils/Strings.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
| import "@openzeppelin/contracts/token/ERC1155/ERC1155.sol"; | ||
| import "@openzeppelin/contracts/utils/Strings.sol"; | ||
|
|
||
| import "./Authorizable.sol"; |
There was a problem hiding this comment.
global import of path ./Authorizable.sol is not allowed. Specify names to import individually or bind all exports of the module into a name (import "path" as Name)
| seriesArtworkMaxSupplies_.length > 0, | ||
| "FeralfileExhibitionV5: seriesArtworkMaxSupplies_ is empty" | ||
| ); | ||
| require( |
There was a problem hiding this comment.
Use Custom Errors instead of require statements
| // initialize max supply map | ||
| for (uint256 i = 0; i < seriesIds_.length; i++) { | ||
| // Check invalid series ID | ||
| require(seriesIds_[i] > 0, "FeralfileExhibitionV5: zero seriesId"); |
There was a problem hiding this comment.
Error message for require is too long: 36 counted / 32 allowed
| // initialize max supply map | ||
| for (uint256 i = 0; i < seriesIds_.length; i++) { | ||
| // Check invalid series ID | ||
| require(seriesIds_[i] > 0, "FeralfileExhibitionV5: zero seriesId"); |
There was a problem hiding this comment.
Use Custom Errors instead of require statements
| // Check invalid series ID | ||
| require(seriesIds_[i] > 0, "FeralfileExhibitionV5: zero seriesId"); | ||
| // Check invalid max supply | ||
| require( |
There was a problem hiding this comment.
Error message for require is too long: 45 counted / 32 allowed
| // Check invalid series ID | ||
| require(seriesIds_[i] > 0, "FeralfileExhibitionV5: zero seriesId"); | ||
| // Check invalid max supply | ||
| require( |
There was a problem hiding this comment.
Use Custom Errors instead of require statements
No description provided.