Allow for registering a new ConvivaAnalyticsIntegration to a reused Player #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
kvolkers
changed the title
dweinber
approved these changes
Jul 17, 2023
There was a problem hiding this comment.
Hi @kvolkers, thank you very much for your contribution! 🎉
The code looks good and I can't see how your changes could lead to the failing tests... plus I'm aware some tests are a bit flaky. Seems unrelated to your PR so good to go 🙂
|
For the record: I merged this into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current setup expects for 1
ConvivaAnalyticsIntegrationinstance to be used with 1BitmovinPlayerinstance.To make it easier to get Conviva to track correctly in our implementation when changing video stream with 1
BitmovinPlayerinstance (live channel zapping, play next, some use cases with chromecast) we'd like to use a newConvivaAnalyticsIntegrationfor each new video stream.The following changes were made:
ConvivaAnalyticsIntegration.release(Boolean releaseConvivaSdk)function. Calling this function withreleaseConvivaSdk = falsepreventsConvivaAnalytics.release()from being called. Otherwise creating a newConvivaAnalyticsIntegrationright after this would result in a broken session ending in an EBVS.ConvivaAnalyticsIntegration.release(Boolean releaseConvivaSdk).ConvivaAnalyticsIntegration.release()convenience function mimicking current behaviour for backwards compatibility.I couldn't get all tests to work, but I suspect this might be an issue with the 2 tests itself, report included.
androidTests.zip