Feature/report play head time #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
dweinber
requested changes
Mar 25, 2024
conviva/src/main/java/com/bitmovin/analytics/conviva/ConvivaAnalyticsIntegration.java
Outdated
Show resolved
Hide resolved
conviva/src/main/java/com/bitmovin/analytics/conviva/ConvivaAnalyticsIntegration.java
Show resolved
Hide resolved
dweinber
approved these changes
Mar 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A new value that is needed in Conviva to get a pass on validation is the playhead time. This can be useful for example in error reporting, to know in what second the user has an issue.
The following changes were made:
TimeChangedcallback for reporting Playhead to conviva playback metric. Calculates Live and Vod playback for reporting.Build has been validated by Conviva:
NLZIET Android 5.0 - App Version 5.7.5: https://pulse.conviva.com/app/appmanager/apps/5389/28241 - #20. Playhead Time (PHT) Passed (https://touchstone-conviva.conviva.com/ui?client=209004308.1313293974.1027138199.1109187838&pub=0&before=1710772679.4021997&session=876273758)
NLZIET Android TV 5.0 App Version 5.7.5: https://pulse.conviva.com/app/appmanager/apps/5392/28242 - 1. Playhead Time (PHT): Pass (https://touchstone-conviva.conviva.com/ui?client=836067775.1698472106.1392489906.2042532197&session=1096631015&pub=0&before=1710771018.5019999)
NLZIET FireTV 5.0 - App Version 5.7.5: Playhead Time (PHT) for VOD : PASSED
Some tests for
./gradlew ConvivaTestApp:connectedAndroidTestseem to fail. I included the report.androidTests.zip