feat: reinitialize player on changes in player config or UI config #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felix-hoc
reviewed
Jun 21, 2024
src/BitmovinPlayer.tsx
Outdated
| return () => { | ||
| destroyPlayer(initializedPlayer, rootContainerElement, createdPlayerContainerElement); | ||
| }; | ||
| }, [config, customUi, playerRefProp]); |
There was a problem hiding this comment.
As discussed, let's check if there are any bad effects from having the ref as a dependency.
There was a problem hiding this comment.
I think it can be done as a separate use effect hook to avoid player reinitialization on the ref property changes - f0703e6.
felix-hoc
approved these changes
Jun 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://bitmovin.atlassian.net/browse/FE-189.
I've been working on the integration of this wrapper into our dashboard during the FE community days and noticed that sometimes we need to keep track of changes in the config and reinitialize the player.
This PR extends the wrapper to also track changes in the configs and reinitialize the player.