fix: use initial player ref to avoid redundant callbacks #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karpov-kir
force-pushed
the
feature/FE-189-use-initial-player-ref
branch
from
2f3a28e to
796c172
Compare
karpov-kir
force-pushed
the
feature/FE-189-use-initial-player-ref
branch
from
796c172 to
d67f524
Compare
karpov-kir
changed the title
felix-hoc
approved these changes
Jun 21, 2024
karpov-kir
force-pushed
the
feature/FE-189-use-initial-player-ref
branch
from
53a2d50 to
714089e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to: https://bitmovin.atlassian.net/browse/FE-189.
The fix avoids unnecessary callbacks when using inline ref functions. Without the fix, the following would invoke the callback unnecessary on re-renders: