Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: pre-commit lint hook #9

Merged
merged 4 commits into from
Apr 23, 2024
Merged

ci: pre-commit lint hook #9

merged 4 commits into from
Apr 23, 2024

Conversation

karpov-kir
Copy link
Contributor

@karpov-kir karpov-kir commented Apr 22, 2024 •
edited
Loading

Related to: https://bitmovin.atlassian.net/browse/TA-2585.

This is going to be used in #10.

@karpov-kir karpov-kir changed the title Feature/ta 2585 pre commit hook ci: pre-commit lint hook Apr 22, 2024
@karpov-kir karpov-kir requested a review from felix-hoc April 22, 2024 09:38
@felix-hoc felix-hoc removed their request for review April 22, 2024 09:57
felix-hoc
felix-hoc reviewed Apr 23, 2024
View reviewed changes
Copy link
Contributor

@felix-hoc felix-hoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just wondering about prettier

package.json Show resolved Hide resolved
@karpov-kir karpov-kir merged commit b9204cc into main Apr 23, 2024
3 checks passed
@karpov-kir karpov-kir deleted the feature/TA-2585-pre-commit-hook branch April 23, 2024 07:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@felix-hoc felix-hoc felix-hoc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@karpov-kir @felix-hoc