Add sprig function library for templating #1542
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes bitnami-labs#1534 and bitnami-labs#1193. Signed-off-by: Jeremy Fleischman <jeremyfleischman@gmail.com>
|
Oh yikes. Sorry, I am a complete go noob. sprig should definitely not be an indirect dependency. Fixed! |
jfly
commented
Jun 7, 2024
alemorcuq
approved these changes
Jun 10, 2024
|
Thanks @jfly ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1534 and #1193.
Description of the change
Add sprig function library for templating
Benefits
As described in #1534, this lets people safely generate more types of configuration (such as yaml files) and safely and correctly escape passwords.
Possible drawbacks
I have not removed
env,expandenv, andgetHostByName, as argocd does. I supposed there's some security concern here? Happy to filter them out if folks like.Applicable issues
Additional information
Thanks for the consideration!