Update install instructions for consistent HTTP request package #1546
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The kubeseal install command instructions for linux contained both wget and curl commands. This change just uses curl. I ran into an issue where I copy and pasted the linux install commands for kubeseal that contained the curl and jq to automatically pull the version number, but I didn't have wget installed. Signed-off-by: Dan Fredell <Dan.Fredell@gmail.com>
dfredell
requested review from
alvneiayu,
agarcia-oss and
alemorcuq
as code owners
alemorcuq
approved these changes
Jun 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The kubeseal install command instructions for linux contained both wget and curl commands. This change just uses curl.
Benefits
Reduce the dependencies need to run a one bash block install of kubeseal.
Possible drawbacks
The user has wget installed but not curl, now both commands (version get, and tar download) will fail.
Additional information
I ran into an issue where I copy and pasted the linux install commands for kubeseal that contained the curl and jq to automatically pull the version number, but I didn't have wget installed.