Adding keyttl and keycutofftime options to helm chart #1610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: rurod <48444553+rurod@users.noreply.github.com>
rurod
force-pushed
the
enhancement/helm-tpl-key-options
branch
from
3b4d673
to
40e94cd
Compare
|
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Hi, this change adds the two following controller flags as options in the helm chart :
Benefits
It allows specifying those options without having to override the default args list defined by the helm chart.
Thus simplifying the early key renewal procedure when Sealed Secrets is deployed through ArgoCD for example.
Possible drawbacks
No drawback identified.
Applicable issues
Did not find an opened issue mentioning this.
Additional information
N/A