Adding support for setting imagePullPolicy: Never for local development #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mkmik
approved these changes
Jul 16, 2019
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 16, 2019
181: Adding support for setting imagePullPolicy: Never for local development r=mkmik a=chrisharm This adds a configuration to the Makefile to pass in a value for imagePullPolicy, so that it doesn't have to be manually modified after it's generated. Co-authored-by: Christopher Harm <crh5255@psu.edu>
Build succeeded |
mkmik
pushed a commit
that referenced
this pull request
Jul 22, 2019
In #181 we made sure the CI was always testing the rigth code during integration tests, but that involved materializing yaml deployment templates that are not suitable for distribution. This PR rebuilds the yaml files from jsonnet, without the image policy = Never override.
bors bot
added a commit
that referenced
this pull request
Jul 22, 2019
194: Ensure image pull policy is not Never r=mkmik a=mkmik In #181 we made sure the CI was always testing the rigth code during integration tests, but that involved materializing yaml deployment templates that are not suitable for distribution. This PR rebuilds the yaml files from jsonnet, without the image policy = Never override. This is what would happen if we released without this PR: ``` NAME READY STATUS RESTARTS AGE sealed-secrets-controller-b85b85fd5-27f82 0/1 ErrImageNeverPull 0 21m ``` Co-authored-by: Marko Mikulicic <mkm@bitnami.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a configuration to the Makefile to pass in a value for imagePullPolicy, so that it doesn't have to be manually modified after it's generated.