Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tag Status field as omitempty #383

Merged
merged 1 commit into from
Mar 27, 2020
Merged

Tag Status field as omitempty #383

merged 1 commit into from
Mar 27, 2020

Conversation

mkmik
Copy link
Collaborator

@mkmik mkmik commented Mar 26, 2020

Checked that nobody depends on the Status field since we're technically breaking source backward compat
https://pkg.go.dev/github.com/bitnami-labs/sealed-secrets@v0.11.0/pkg/apis/sealed-secrets/v1alpha1?tab=doc#SealedSecretStatus

@mkmik mkmik requested a review from atomatt March 26, 2020 16:23
cmd/controller/controller.go Outdated Show resolved Hide resolved
Checked that nobody depends on the Status field since we're technically breaking source backward compat
https://pkg.go.dev/github.com/bitnami-labs/sealed-secrets@v0.11.0/pkg/apis/sealed-secrets/v1alpha1?tab=doc#SealedSecretStatus
@mkmik
Copy link
Collaborator Author

mkmik commented Mar 27, 2020

bors r+

@bors
Copy link
Contributor

bors bot commented Mar 27, 2020

Build succeeded

@bors bors bot merged commit 1a1e4f3 into master Mar 27, 2020
@bors bors bot deleted the noempty branch March 27, 2020 15:37
@mkmik mkmik added this to the v0.12.0 milestone Mar 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants