Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sentinel PodDisruptionBudget condition #30482

Open
tristan-ludlow opened this issue Nov 15, 2024 · 1 comment
Open

Fix Sentinel PodDisruptionBudget condition #30482

tristan-ludlow opened this issue Nov 15, 2024 · 1 comment
Assignees
Labels
tech-issues The user has a technical issue about an application triage Triage is needed valkey

Comments

@tristan-ludlow
Copy link

tristan-ludlow commented Nov 15, 2024

Name and Version

bitnami/valkey

What architecture are you using?

amd64

What steps will reproduce the bug?

When the valkey chart is installed with the default values file and a disabled Sentinel, the Pdb for the Sentinel still gets created. I believe it is the same problem that requires the same fix applied for Redis here:

#27080

The condition on line 6 of bitnami/valkey/templates/sentinel/pdb.yaml needs to be reversed:

{{- if and (eq .Values.architecture "replication") (not .Values.sentinel.enabled) .Values.replica.pdb.create }}

What is the expected behavior?

Stop creating the unnecessary PDB when sentinel is not enabled.

What do you see instead?

A useless PDB gets created for sentinel when sentinel itself is disabled.

@tristan-ludlow tristan-ludlow added the tech-issues The user has a technical issue about an application label Nov 15, 2024
@github-actions github-actions bot added the triage Triage is needed label Nov 15, 2024
@carrodher
Copy link
Member

Thank you for bringing this issue to our attention. We appreciate your involvement! If you're interested in contributing a solution, we welcome you to create a pull request. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community. Feel free to reach out if you have any questions or need assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tech-issues The user has a technical issue about an application triage Triage is needed valkey
Projects
None yet
Development

No branches or pull requests

3 participants