Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/redis] Fix sentinel PDB condition #27080

Merged
merged 7 commits into from
Jun 13, 2024

Conversation

fmulero
Copy link
Collaborator

@fmulero fmulero commented Jun 10, 2024

Description of the change

Fix mistake in the condition what enables the PodDisruptionBudgets for sentinel.

Benefits

Remove unnecessary PDB created when sentinel is not enabled.

Possible drawbacks

None

Applicable issues

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [NA] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

Signed-off-by: Fran Mulero <fmulero@vmware.com>
@fmulero fmulero enabled auto-merge (squash) June 10, 2024 16:26
@github-actions github-actions bot added the redis label Jun 10, 2024
@bitnami-bot bitnami-bot added the verify Execute verification workflow for these changes label Jun 10, 2024
@github-actions github-actions bot requested a review from juan131 June 10, 2024 16:26
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Copy link

@wouterh wouterh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe there's something wrong with the condition for creating the master PDB too. In my configuration, it created a PDB for the masters while the master statefulset is not created:

$ kubectl -n redis get pdb -o jsonpath="{.items[].metadata.name} {.items[].spec.selector} {.items[].status.expectedPods}"
redis-master {"matchLabels":{"app.kubernetes.io/component":"master","app.kubernetes.io/instance":"redis","app.kubernetes.io/name":"redis"}} 0

$ kubectl -n redis get sts
NAME         READY   AGE
redis-node   3/3     472d

bitnami/redis/templates/sentinel/pdb.yaml Outdated Show resolved Hide resolved
fmulero and others added 5 commits June 12, 2024 09:54
Signed-off-by: Fran Mulero <fmulero@vmware.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
Signed-off-by: Fran Mulero <fmulero@vmware.com>
@juan131 juan131 merged commit 2d8e19f into bitnami:main Jun 13, 2024
19 checks passed
@fmulero fmulero deleted the bugfix/redis-sentinel-pdb branch June 13, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bitnami redis solved verify Execute verification workflow for these changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants