Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/nginx] Fix rendering of CIDR block list for loadBalancerSourceRanges #14836

Merged
merged 1 commit into from
Feb 13, 2023
Merged

[bitnami/nginx] Fix rendering of CIDR block list for loadBalancerSourceRanges #14836

merged 1 commit into from
Feb 13, 2023

Conversation

danil-smirnov
Copy link
Contributor

@danil-smirnov danil-smirnov commented Feb 10, 2023 •
edited
Loading

Description of the change

This is the same change as #14455 but for the nginx chart.

Benefits

Possible drawbacks

Applicable issues

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the nginx label Feb 10, 2023
@danil-smirnov danil-smirnov changed the title [bitnami/nginx] Fix rendering of CIDR block list for loadBalancerSour… [bitnami/nginx] Fix rendering of CIDR block list for loadBalancerSourceRanges Feb 10, 2023
@github-actions github-actions bot added the triage Triage is needed label Feb 10, 2023
@danil-smirnov
[bitnami/nginx] Fix rendering of CIDR block list for loadBalancerSour…
c948397 
…ceRanges

Signed-off-by: Danil Smirnov <danil@smirnov.la>
@carrodher carrodher added the verify Execute verification workflow for these changes label Feb 12, 2023
@bitnami-bot bitnami-bot removed the request for review from carrodher February 12, 2023 21:03
@github-actions github-actions bot added in-progress and removed triage Triage is needed labels Feb 12, 2023
@carrodher carrodher mentioned this pull request Feb 12, 2023
Closed
4 tasks
aoterolorenzo
aoterolorenzo approved these changes Feb 13, 2023
View reviewed changes
Copy link
Contributor

@aoterolorenzo aoterolorenzo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution! LGTM

@aoterolorenzo aoterolorenzo merged commit cfbfe86 into bitnami:main Feb 13, 2023
rafariossaa pushed a commit to rafariossaa/charts that referenced this pull request Feb 17, 2023
@danil-smirnov @rafariossaa
[bitnami/nginx] Fix rendering of CIDR block list for loadBalancerSour…
372d417 
…ceRanges (bitnami#14836)

Signed-off-by: Danil Smirnov <danil@smirnov.la>
koraven pushed a commit to koraven/charts that referenced this pull request Mar 2, 2023
@danil-smirnov
[bitnami/nginx] Fix rendering of CIDR block list for loadBalancerSour…
5a8642b 
…ceRanges (bitnami#14836)

Signed-off-by: Danil Smirnov <danil@smirnov.la>
koraven pushed a commit to koraven/charts that referenced this pull request Mar 2, 2023
@danil-smirnov
[bitnami/nginx] Fix rendering of CIDR block list for loadBalancerSour…
2b9a411 
…ceRanges (bitnami#14836)

Signed-off-by: Danil Smirnov <danil@smirnov.la>
This was referenced Dec 12, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aoterolorenzo aoterolorenzo aoterolorenzo approved these changes

Assignees

@aoterolorenzo aoterolorenzo

Labels
nginx solved verify Execute verification workflow for these changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bitnami/nginx] loadBalancerSourceRanges list rendering is broken
3 participants
@danil-smirnov @aoterolorenzo @carrodher