Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/rabbitmq] Introduced .Release.Namespace in objects meta #2144

Closed
wants to merge 1 commit into from
Closed

[bitnami/rabbitmq] Introduced .Release.Namespace in objects meta #2144

wants to merge 1 commit into from

Conversation

glothriel
Copy link
Contributor

Description of the change

This PR adds .Release.Namespace to objects meta for Rabbitmq charts. Related to discussion in this issue.

Benefits

Ability to use the helm chart when having declarative definition of all cluster objects rendered using helm template.

Possible drawbacks

I don't see any, it will work as previously for helm install.

Applicable issues

#2006

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

Copy link
Contributor

@juan131 juan131 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving your changes! @javsalgar please also check this PR

@juan131 juan131 added the on-hold Issues or Pull Requests with this label will never be considered stale label Mar 27, 2020
@juan131
Copy link
Contributor

juan131 commented Mar 27, 2020

Waiting for CI/CD to update tags

@juan131
Copy link
Contributor

juan131 commented Mar 27, 2020

Hi @glothriel

In order to update the image tags to point to latest releases, our CI/CD needs to modify you PR (bitnami-bot will update values.yaml and values-production.yaml for you). To do so, it's necessary you allow "edits from maintainers". Find more information in the link below:

@glothriel
Copy link
Contributor Author

glothriel commented Mar 27, 2020

Hi @juan131

Oke so it looks we have a problem with how Github works: isaacs/github#1681

I don't see given checkbox at all. The above issue suggests adding user explicitly to source repo with "write" access, I can do that with @bitnami-bot I guess?

@glothriel
Copy link
Contributor Author

Guys, to avoid future problems & questionable "write" access to whole repo, I will just create the same PR from my private fork, so I'm closing this one. Sorry for inconvenience.

@glothriel glothriel closed this Mar 29, 2020
@juan131
Copy link
Contributor

juan131 commented Mar 30, 2020

Thanks so much @glothriel ! Checking new PRs!

@carrodher carrodher removed the on-hold Issues or Pull Requests with this label will never be considered stale label Dec 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants