Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bitnami/consul] Introduced .Release.Namespace in objects meta #2761

Merged
merged 3 commits into from
Jun 9, 2020
Merged

[bitnami/consul] Introduced .Release.Namespace in objects meta #2761

merged 3 commits into from
Jun 9, 2020

Conversation

glothriel
Copy link
Contributor

Description of the change

Hi, it's me again :-)
The PR is connected with issue #2006
and follows the same scheme as:

Benefits

TLDR; ability to deploy the helm chart in gitops-friendly way, for details read the issue here: #2006

Possible drawbacks

Not known

Applicable issues

#2006

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the README.md
  • Title of the PR starts with chart name (e.g. [bitnami/chart])
  • If the chart contains a values-production.yaml apart from values.yaml, ensure that you implement the changes in both files

⚠️ Keep in mind that if you want to make changes to the kubeapps chart, please implement them in the kubeapps repository. This is only a synchronized mirror.

@rafariossaa
Copy link
Contributor

Hi @glothriel ,
Thanks for the PR !,
LGTM.
Waiting for the CI/CD.

Copy link
Contributor

@rafariossaa rafariossaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bitnami-bot
Copy link
Contributor

I have just updated the bitnami images with the latest known immutable tags:

  • "docker.io/bitnami/consul:1.7.3-debian-10-r13"
  • "docker.io/bitnami/consul-exporter:0.6.0-debian-10-r136"
  • "docker.io/bitnami/minideb:buster"

@glothriel
Copy link
Contributor Author

@rafariossaa Hi, are any additional steps required from my side?

@rafariossaa rafariossaa merged commit 752cb53 into bitnami:master Jun 9, 2020
@rafariossaa
Copy link
Contributor

Hi @glothriel ,
No, nothing is required on you side. Sorry for the delay.

Best regards,

@glothriel glothriel deleted the consul-introduce-release-namespace branch June 9, 2020 07:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants