Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bitnami/*] Fix typo in README #31052

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[bitnami/*] Fix typo in README #31052

merged 2 commits into from
Dec 16, 2024

Conversation

ziyue-pan
Copy link
Contributor

@ziyue-pan ziyue-pan commented Dec 16, 2024 •
edited
Loading

Description of the change

Fix a typo in all READMEs, from resourcePreset to resourcesPreset. This typo bothered me when I tried to deploy memcached. And I noticed exactly the same typo in other READMEs.

Benefits

Possible drawbacks

Applicable issues

  • fixes #

Additional information

Checklist

  • Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • All commits signed off and in agreement of Developer Certificate of Origin (DCO)

@github-actions github-actions bot added the triage Triage is needed label Dec 16, 2024
@github-actions github-actions bot requested a review from carrodher December 16, 2024 09:56
@ziyue-pan
Fix typo in memcached/README
0a668c7 
Signed-off-by: Ziyue Pan <ziyuepan1999@gmail.com>
@ziyue-pan
Fix all resourcePreset in documents
f89fb0e 
Signed-off-by: Ziyue Pan <ziyuepan1999@gmail.com>
carrodher
carrodher approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@carrodher carrodher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for addressing this issue.
LGTM

@carrodher carrodher merged commit b41a51d into bitnami:main Dec 16, 2024
11 checks passed
ramezbenaribia pushed a commit to ramezbenaribia/charts that referenced this pull request Dec 16, 2024
@ziyue-pan @ramezbenaribia
[bitnami/*] Fix typo in README (bitnami#31052)
f4c0918 
* Fix typo in memcached/README

Signed-off-by: Ziyue Pan <ziyuepan1999@gmail.com>

* Fix all `resourcePreset` in documents

Signed-off-by: Ziyue Pan <ziyuepan1999@gmail.com>

---------

Signed-off-by: Ziyue Pan <ziyuepan1999@gmail.com>
Signed-off-by: Ramez Ben Aribia <ramezbenaribia@gmail.com>
ramezbenaribia pushed a commit to ramezbenaribia/charts that referenced this pull request Dec 16, 2024
@ziyue-pan @ramezbenaribia
[bitnami/*] Fix typo in README (bitnami#31052)
992ea10 
* Fix typo in memcached/README

Signed-off-by: Ziyue Pan <ziyuepan1999@gmail.com>

* Fix all `resourcePreset` in documents

Signed-off-by: Ziyue Pan <ziyuepan1999@gmail.com>

---------

Signed-off-by: Ziyue Pan <ziyuepan1999@gmail.com>
Signed-off-by: Ramez Ben Aribia <ramezbenaribia@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carrodher carrodher carrodher approved these changes

Assignees

@carrodher carrodher

Labels
solved triage Triage is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ziyue-pan @carrodher