[bitnami/fluent-bit] Fix typo daemonset.enable #31088
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eugene70
force-pushed
the
fluent-bit-pdb-fix
branch
from
9c8f644 to
3adfd76
Compare
eugene70
changed the title
eugene70
force-pushed
the
fluent-bit-pdb-fix
branch
from
3adfd76 to
1998d01
Compare
|
Thanks for your contribution! Could you please bump the chart version in the Chart.yaml? This is necessary to test the changes and cut a new release. |
eugene70
force-pushed
the
fluent-bit-pdb-fix
branch
from
1998d01 to
72e2561
Compare
|
Changed |
|
I just discovered other templates with the same issue in this chart, taking advantage of this PR, would you mind fixing them as well? See $ ag 'daemonset\.enable'
templates/vpa.yaml
35: kind: {{ ternary "DaemonSet" "Deployment" .Values.daemonset.enable }}
templates/pdb.yaml
6:{{- if and .Values.pdb.create (not .Values.daemonset.enable) }}
templates/hpa.yaml
6:{{- if and (not .Values.daemonset.enable) .Values.autoscaling.hpa.enabled }} |
Signed-off-by: Eugene Kim <eugene70kim@gmail.com>
eugene70
changed the title
eugene70
force-pushed
the
fluent-bit-pdb-fix
branch
from
6cfca2b to
1dcf820
Compare
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
|
Fixed all and changed title. |
carrodher
added
verify
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
alvneiayu
previously approved these changes
Dec 20, 2024
Signed-off-by: Alvaro Neira Ayuso <alvaroneay@gmail.com>
Signed-off-by: Alvaro Neira Ayuso <alvaro.neira@broadcom.com>
Signed-off-by: Bitnami Containers <bitnami-bot@vmware.com>
alvneiayu
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a typo in the condition for generating pdb as described in issue #30539. We need to change enable to enabled.
The issue closed, but not solved.