-
Notifications
You must be signed in to change notification settings - Fork 49
[jjo] support Kubernetes v1.22+ apiVersions deprecations #61
[jjo] support Kubernetes v1.22+ apiVersions deprecations #61
Conversation
Fixes bitnami#60. Support Kubernetes v1.22+ apiVersions deprecations, notably: * `Ingress`: - use `apiVersion: networking.k8s.io/v1` - create (and populate) `service` field to each `path` (previously `serviceName` and `servicePort`) - `bitnami.libsonnet`: use `pathType: ImplementationSpecific`, which seems to be the most generic one * `CustomResourceDefinition`: - use `apiVersion: apiextensions.k8s.io/v1` - create `versions` map with sensible defaults, including `spec` field, as commonly used fro CRs Other changes: * `tests/Makefile`: support (only) v1.19+ * `tests/init-kube.jsonnet`: CRD tweaks FYI this is on top of bitnami#59.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it looks good to me, thanks a lot for the contribution @jjo :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this! SGTM
It seems this PR is going to cause some issues.
And the Ingress resource I'm testing is:
Checking-out the official docs, it seems they also stopped adding the port number and name:
|
Given this is nowadays breaking some of our Continuous Deployment pipelines that are sticking to the latest kube-libsonnet, I would rather revert this PR until some changes are made (code / tests) so we stop setting the port name (I don't see the point on having a custom name there). What do you think @jjo, @jbianquetti-nami ? |
Gah sorry for that ! :( |
Fixes #60.
Support Kubernetes v1.22+ apiVersions deprecations, notably:
Ingress
:apiVersion: networking.k8s.io/v1
service
field to eachpath
(previously
serviceName
andservicePort
)bitnami.libsonnet
: usepathType: ImplementationSpecific
, which seems to be themost generic one
CustomResourceDefinition
:apiVersion: apiextensions.k8s.io/v1
versions
map with sensible defaults, includingspec
field, as commonly used fro CRs
Other changes:
tests/Makefile
: support (only) v1.19+tests/init-kube.jsonnet
: CRD tweaksFYI this is on top of #59.
NOTE: once merged upstream, would strongly recommend tagging it as
v1.19.0
, following the convention that tags'<major>.<minor>
should express minimum required Kubernetes release.