TR-22: Refactor rollup/percent-complete #197
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binaryberserker
commented
Oct 23, 2024
| const groupedIssueData = groupIssuesByHierarchyLevel(completionRollups); | ||
|
|
||
| // Object.groupBy requires "target: ESNext" in tsconfig | ||
| const issueKeyToChildren = Object.groupBy( |
There was a problem hiding this comment.
Note: Object.groupBy is only available in the ESNext target, so preserving the existing code as much as possible meant changing tsconfig target from ES2020 to ESNext
binaryberserker
force-pushed
the
dbrandon/TR-22
branch
from
77198e5
to
36aa420
Compare
binaryberserker
force-pushed
the
dbrandon/TR-22
branch
from
d65a5bc
to
39c7bee
Compare
binaryberserker
commented
Oct 29, 2024
| @@ -1,6 +1,7 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "ES2020", | |||
| "target": "ESNext", | |||
There was a problem hiding this comment.
percent complete is using Object.groupBy, which is only available in ESNext
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.