Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CamelCase property should be reflected to dashed attributes #17

Closed
psamusev opened this issue Jun 30, 2021 · 3 comments · Fixed by #29
Closed

CamelCase property should be reflected to dashed attributes #17

psamusev opened this issue Jun 30, 2021 · 3 comments · Fixed by #29
Assignees
@janebitovi
Labels
accepted Accepted for development enhancement New feature or request

Comments

@psamusev
Copy link
Contributor

Current approach assume attributes in same name as properties, however for complex names, i.e. 'pureString` attribute name should be considered in dashed style (or at least let the possibility to specify the attribute name)
psamusev added a commit to psamusev/react-to-webcomponent that referenced this issue Jun 30, 2021
@psamusev
Fixed bitovi#17 Support of dashed attributes styling
cc58245
@psamusev
Copy link
Contributor Author

Please see the proposed idea in PR

@justinbmeyer
Copy link
Member

Thanks for the PR!

@justinbmeyer
Copy link
Member

I think we need to update the readme along with the PR

janebitovi added a commit that referenced this issue May 18, 2022
@janebitovi
for #17 - option to convert dashed-attributes to camelCase react props
81767b2
@janebitovi janebitovi mentioned this issue May 18, 2022
Merged
@christopherjbaker christopherjbaker added accepted Accepted for development enhancement New feature or request labels May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janebitovi janebitovi

Labels
accepted Accepted for development enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

option to convert dashed-attributes to camelCase react props bitovi/react-to-web-component
4 participants
@justinbmeyer @christopherjbaker @psamusev @janebitovi