fix: Remove style attribute from body for prevent unexpected background #382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alfonso-salces
added a commit
to alfonso-salces/cordova-plugin-qrscanner
that referenced
this pull request
Sep 5, 2022
alfonso-salces
added a commit
to moodlemobile/cordova-plugin-qrscanner
that referenced
this pull request
Sep 5, 2022
alfonso-salces
force-pushed
the
main
branch
from
c5b2b13 to
1baa60d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current version of the plugin, when user leaves the qr scanner, this plugin remove the inline styles that we have in body tag before open qr scanner.
With this PR, save the styles that we have in body tag before open scanner and when scanner is getting closed, then we rewrite the styles in body tag.