Do not rely on _makeitem when collecting instances #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SpecInstance relys on _makeitem to construct any instance, which was removed in pytest 6.1. Instead of overriding that method, define a collect method that knows how to recurse. Fixes bitprophet#12
|
This has been broken by pytest 7.1 again: https://docs.pytest.org/en/latest/deprecations.html#the-pytest-instance-collector |
|
s-t-e-v-e-n-k#1 enhances this to keep it working with pytest 7. Tested with pytest 3.10 (openSUSE Leap 15.3 python devel project), pytest 6.2 (current Tumbleweed) and pytest 7.1 (upcoming update for Tumbleweed). |
|
Ah, I noticed there is also #10 included into the commit. Oh my. |
|
This should be fixed as of the latest major release! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SpecInstance relys on _makeitem to construct any instance, which was
removed in pytest 6.1. Instead of overriding that method, define a
collect method that knows how to recurse.
Fixes #12