Handle new package file #46
Conversation
tothszabi
force-pushed
the
handle-new-package-file
branch
from
52c8bd7
to
b50b5a1
Compare
| Packages []struct { | ||
| Name string `json:"name"` | ||
| RootUri string `json:"rootUri"` | ||
| PackageUri string `json:"packageUri"` |
There was a problem hiding this comment.
Looking at https://dart.googlesource.com/sdk/+/5ae183856945440597e0674436dd89b9e08632bc/.dart_tool/package_config.json as an example, at least packageUri can be missing. Should this field rather be string? and omitempty?
There was a problem hiding this comment.
Go does not have optional fields and the way it works is that it initialises every field to the fields default value. For strings this is the "" empty string. Which is great for us and this way we do not need to care if the packageUri exists or not.
The omitempty tag is only useful for encoding. It is not used during decoding.
There was a problem hiding this comment.
Don't know what is exactly the rule here.
But in my old team we usually approved the code pro-actively allowing the author to fix comments and tests and merge without blockers.
Approved =)
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
The e2e tests started to fail on the Linux stack. After some investigation I have found that the Dart team deprecated the way they were handling the packages and now there is a new json based variant:
dart-lang/sdk#48272
They were generously generating the old version too for backwards compatibility but after a certain version it will be completely removed.
This PR introduces handling this new json format.
Changes
The step will first try to parse the old
.packagesfile. If it fails then it will also try to parse the new.dart_tool/package_config.jsonone.