Remove signature with vanilla zip #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpusok
reviewed
Dec 18, 2020
main.go
Outdated
| func removeFilesFromBuildArtifact(aapt, pth string, files []string) error { | ||
| cmdSlice := append([]string{aapt, "remove", pth}, files...) | ||
| func removeFilesFromBuildArtifact(pth string, files []string) error { | ||
| cmdSlice := append([]string{"zip", "-d", pth}, files...) |
There was a problem hiding this comment.
For consistency, it would be nice to print the full path of the zip binary in the command, or at the beginning of the step using exec.LookPath. (Also aapt path is printed, but it is not used anymore)
lpusok
reviewed
Dec 18, 2020
step.yml
Outdated
| @@ -47,9 +47,11 @@ is_skippable: false | |||
| deps: | |||
| brew: | |||
| - name: go | |||
There was a problem hiding this comment.
A sidenote: go does not need to be added as a dependency, based on the guide: https://devcenter.bitrise.io/contributors/create-your-own-step/#submodules-and-step-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use zip to remove items from apk as aapt seems to be generating corrupt zip files.
Test project: https://app.bitrise.io/app/864f8dcf926d2b55#/builds
STEP-2