Add context to error messages #78
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofalvai
commented
Feb 21, 2022
| @@ -370,9 +370,6 @@ func main() { | |||
| signedAPKPaths = append(signedAPKPaths, fullPath) | |||
| } | |||
|
|
|||
| if err != nil { | |||
There was a problem hiding this comment.
This was checking an err instance assigned waaay earlier, I don't think we need this here.
shams-ahmed
previously approved these changes
Feb 21, 2022
tothszabi
approved these changes
Feb 22, 2022
There was a problem hiding this comment.
The PR looks good. This comment is more of an observation.
I have seen export related methods where apk and aab are exported and if an error happens here then we treat it as a warning instead of an error. It is true that these are just env var exports and use envman but I do wonder if this old logic is correct.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a PATCH version update
Context
Adding more context to error messages printed to build log.
Changes
Add context prefix to
failf()callsInvestigation details
Decisions