Replace use_apk_signer with signer_tool step input #88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tothszabi
reviewed
Oct 1, 2024
main.go
Outdated
| @@ -230,6 +238,11 @@ func validate(cfg configs) error { | |||
| } else if !exist { | |||
| return fmt.Errorf("BuildArtifactPath not exist at: %s", buildArtifactPath) | |||
| } | |||
|
|
|||
| signAAB := strings.EqualFold(buildArtifactPath, ".aab") | |||
There was a problem hiding this comment.
I think you are comparing a full path with the .aab extension here.
There was a problem hiding this comment.
Ouch good catch, I tried to copy the logic from here: https://github.com/bitrise-steplib/steps-sign-apk/pull/88/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261L340
Fixed in 7f57b03
tothszabi
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
step.ymlandREADME.mdis updated with the changes (if needed)Version
Requires a MAJOR version update
Context
The Step currently uses
jarsignerby default for signing APK files (use_apk_signer: "false"), this PR switches toapksigneras a default tool for signing APK files.The change is done by introducing a new step input
signer_toolwhich replaces the previoususe_apk_signerinput.signer_toolindicates which tool should be used for signing the app, the available options:automatic(default value): Uses theapksignertool to sign an APK andjarsignertool to sign an AAB file.apksigner: Uses theapksignertool to sign the app.jarsigner: Uses thejarsignertool to sign the app.Changes
signer_toolreplaces the previoususe_apk_signerinputtest_apk->test_apk_signingtest_apk_debug->test_debug_apk_signingtest_bundle->test_app_bundle_signing_run_collection->_build_app_and_sign_with_keystore_combinationsutility_test_<test_name>->_sign_with_<test_name>_run->_sign_app_jarsigner_all_testsand_apksigner_all_testsworkflows are removed and_sign_with_jarsigner_with_keystore_with_same_passand_sign_with_apksigner_with_keystore_with_diff_passworkflows are testing the none default signer tool inputs