add es-objects-start-es-after-block option #1541
Merged
+83
−79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
reviewed
Jan 26, 2019
| @@ -63,6 +63,7 @@ class es_objects_plugin_impl | |||
| bool _es_objects_limit_orders = true; | |||
| bool _es_objects_asset_bitasset = true; | |||
| std::string _es_objects_index_prefix = "objects-"; | |||
| uint32_t _es_objects_start_es_after_block = 0; // disabled | |||
There was a problem hiding this comment.
No special handling needed for value 0 - it simply means start immediately.
pmconrad
reviewed
Jan 26, 2019
| remove_from_database(ba->id, "bitasset"); | ||
| else | ||
| prepareTemplate<asset_bitasset_data_object>(*ba, "bitasset"); | ||
| if(_es_objects_start_es_after_block == 0 || block_number > _es_objects_start_es_after_block) { |
There was a problem hiding this comment.
Can remove the == 0 check here, since if it is 0 then block_number will always be greater than that.
|
Thank you @pmconrad . I followed your suggestions in |
16 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
es-objects-start-es-after-blockto es-objects plugin which is similar toelasticsearch-start-es-after-blockfor elasticsearch.Nodes can have crashes or other issues, this option is a time saver as it allow to skip blocks until we want, speeding up for example a reindex process.