replace smart_ref with shared_ptr #1556
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
reviewed
Feb 5, 2019
pmconrad
reviewed
Feb 5, 2019
pmconrad
reviewed
Feb 5, 2019
pmconrad
reviewed
Feb 5, 2019
pmconrad
previously approved these changes
Feb 6, 2019
pmconrad
modified the milestones:
Future Feature Release,
201905 - Consensus-Upgrade Release
ryanRfox
modified the milestones:
201905 - Consensus-Upgrade Release,
Future Consensus-Upgrade Release
|
I believe all to be fine with this PR, but am attempting to test some backward-compatibility stuff, to assure that nodes with and without this change still play well together. When testing is complete, I will merge this in. |
pmconrad
approved these changes
Feb 16, 2019
Merged
This was referenced Feb 18, 2019
abitmore
modified the milestones:
Future Feature Release,
Possible 201904 Feature Release
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Potential fix for #1548
The use of fc::smart_ref was to allow for compilation of current_fees while there is a circular reference between fee_schedule, chain_parameters, and operations. But its use is problematic (build errors).
One potential replacement was to switch to unique_ptr. Unfortunately, this does not permit circular references (no copies allowed, full implementation needed for destruction).
shared_ptr will allow circular references. This PR uses shared_ptr to replace fc::smart_ref