Improve the serializer to fix #1701 #1702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmconrad
approved these changes
Apr 29, 2019
|
Merging since it's a step in the right direction. Suggest to keep #1701 open for further improvements. |
|
Merging this has introduced a regression - it uses |
pmconrad
added a commit
to pmconrad/bitshares-core
that referenced
this pull request
Apr 29, 2019
jmjatlanta
added a commit
that referenced
this pull request
Apr 29, 2019
Fixed regression in #1702 - removed obsolete smart_ref
17 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the serializer to match the output used in bitsharesjs these days.