Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove useless code #2086

Merged
merged 3 commits into from
Dec 25, 2019
Merged

Remove useless code #2086

merged 3 commits into from
Dec 25, 2019

Conversation

spartucus
Copy link
Contributor

No description provided.

@abitmore
Copy link
Member

abitmore commented Dec 23, 2019 •
edited
Loading

Thanks. The data type is referenced here:

bitshares-core/libraries/protocol/include/graphene/protocol/account.hpp

Line 125 in e8567d0

* See @ref account_object::options_type for the options which may be updated.
. Perhaps update the comment as well.

@abitmore abitmore added this to the 4.1.0 - Feature Release milestone Dec 23, 2019
abitmore
abitmore reviewed Dec 24, 2019
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

libraries/protocol/include/graphene/protocol/account.hpp Outdated Show resolved Hide resolved
abitmore
abitmore approved these changes Dec 25, 2019
View reviewed changes
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@abitmore abitmore merged commit 0f0a00f into bitshares:develop Dec 25, 2019
@spartucus spartucus deleted the develop branch December 26, 2019 01:35
@abitmore abitmore mentioned this pull request Sep 20, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abitmore abitmore abitmore approved these changes

Assignees
No one assigned
Labels
code cleanup
Projects
None yet
Milestone
5.0.0 - Protocol Upgrade Release
Development

Successfully merging this pull request may close these issues.
2 participants
@spartucus @abitmore