Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add market history plugin asserts #2158

Merged
merged 2 commits into from
Jun 4, 2020
Merged

Conversation

oxarbitrage
Copy link
Member

Fix for issue #2021

I was expecting that calls like get_account_history and related will need account_history_plugin however it seems this is not the case as when i added asserts i got failures in the history_api_tests.

So i left those alone and just added asserts to the ones related to market_history_plugin where missing. This are are the same calls mentioned in the issue: get_fill_order_history and get_market_history.

@abitmore
Copy link
Member

Thanks.
We'll need to think about the account history APIs later. It's more about how clients handle the errors (will the change break the client apps).

@abitmore abitmore added this to the 4.1.0 - Feature Release milestone May 3, 2020
Copy link
Member

@abitmore abitmore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

@abitmore abitmore merged commit fbbc691 into bitshares:develop Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants