-
Notifications
You must be signed in to change notification settings - Fork 648
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
changes to intense block_tests #718
Conversation
Any idea why these tests are not in the regular test suite? Just because they take longer to run? |
Read the commit message of cryptonomex/graphene@b134fbe:
|
Should we move them back to regular test suite? |
On my machine, the modified intense_test takes 6 seconds, chain_test takes 48. |
ok, moving them back to regular test suite. @pmconrad you think including them in |
block_tests makes the most sense IMO. |
moved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please merge this. |
changes discussed at #565
update_account_keys
test.use_address
support ofupdate_account_keys
test as it is not allowed in live chain.witness_order_mc_test
was commented out as it will fail because the feature is not currently implemented however i decided to keep it commented as we might add this in the future, also the monte carlo approach can help as a guide for other tests.bulk_discount
test was removed fully as the feature is not available in the core since a lot, never was live.