-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set default-features = false
on rkyv
#416
Set default-features = false
on rkyv
#416
Conversation
7fbdf44
to
4100cb1
Compare
So that when building `--all-features` (turns on `rkyv`) `--all-targets` (builds `benches` etc), there is no error that at least one `size_xx` must be set.
4100cb1
to
5ccc681
Compare
@bitshifter what's your preference to set these "required" features on dependent crates to have the least friction while developing |
I suspect I left default features enabled on rkyv because I ran into this problem. Ideally default features would be disabled for all dependencies. I wonder if there is something rkyv could do to make this easier to deal with. |
@bitshifter Unfortunately I don't think |
I guess I can live with rkyv being a dev-dependency. Adding |
@bitshifter that works indeed. I'm not too keen on having it hardcoded there, but it seems to be the only solution 👌 |
Using default features pulls in the
size_32
feature, but the choice of thesize_x
feature should be left to the top-level crate as it was thought of in #223 (comment) and #223 (comment), and should be working now thatglam-rs
is on edition 2021 and rust >= 1.50.