Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ops propagation #549

Merged
merged 4 commits into from
Aug 16, 2024
Merged

Ops propagation #549

merged 4 commits into from
Aug 16, 2024

Conversation

Aceeri
Copy link
Contributor

@Aceeri Aceeri commented Aug 15, 2024 •
edited
Loading

Fixes #335

TODO:

  • Add/Sub/Mul/Div/Rem
  • AddAssign/SubAssign/MulAssign/DivAssign/RemAssign
  • Neg

Maybe todo?

  • Not
  • BitAnd/BitOr/BitXor
  • Shl/Shr
  • Product/Sum
  • From

@Aceeri Aceeri changed the title Operation propagation initials Ops propagation Aug 15, 2024
@Aceeri Aceeri marked this pull request as ready for review August 15, 2024 21:10
@bitshifter bitshifter merged commit 913395d into bitshifter:main Aug 16, 2024
18 checks passed
@bitshifter
Copy link
Owner

Thanks for that. It would probably make sense to do the rest although they are probably less commonly used. At some point I might try add these via the codegen template system to make maintenance easier but this is a good start.

@Aceeri Aceeri deleted the issue-335 branch August 19, 2024 00:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bitshifter bitshifter bitshifter left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement std::ops traits on references
2 participants
@Aceeri @bitshifter