revert to old secrets masking behaviour in browser cipher edit view (#…

…8018)
bitwarden · Feb 23, 2024 · 44bda82 · 44bda82
1 parent c6b0f70
commit 44bda82
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 20 deletions.
diff --git a/apps/browser/src/vault/popup/components/vault/add-edit.component.html b/apps/browser/src/vault/popup/components/vault/add-edit.component.html
@@ -70,18 +70,15 @@ <h2 class="box-header">
             <div class="row-main">
               <label for="loginPassword">{{ "password" | i18n }}</label>
               <input
-                *ngIf="showPassword"
                 id="loginPassword"
                 class="monospaced"
-                type="text"
+                type="{{ showPassword ? 'text' : 'password' }}"
                 name="Login.Password"
                 [(ngModel)]="cipher.login.password"
                 appInputVerbatim
+                [disabled]="!cipher.viewPassword"
                 [readonly]="!cipher.edit && editMode"
               />
-              <div *ngIf="!showPassword" class="monospaced">
-                {{ cipher.login.maskedPassword || "••••••••" }}
-              </div>
             </div>
             <div class="action-buttons">
               <button
@@ -153,18 +150,15 @@ <h2 class="box-header">
             <div class="row-main">
               <label for="loginTotp">{{ "authenticatorKeyTotp" | i18n }}</label>
               <input
-                *ngIf="showTotpSeed"
                 id="loginTotp"
-                type="text"
+                type="{{ showTotpSeed ? 'text' : 'password' }}"
                 name="Login.Totp"
                 class="monospaced"
                 [(ngModel)]="cipher.login.totp"
                 appInputVerbatim
+                [disabled]="!cipher.viewPassword"
                 [readonly]="!cipher.edit && editMode"
               />
-              <div *ngIf="!showTotpSeed" class="monospaced">
-                {{ cipher.login.maskedPassword || "••••••••" }}
-              </div>
             </div>
             <div class="action-buttons">
               <button

diff --git a/libs/angular/src/vault/components/add-edit.component.ts b/libs/angular/src/vault/components/add-edit.component.ts
@@ -226,8 +226,6 @@ export class AddEditComponent implements OnInit, OnDestroy {
     if (!this.allowPersonal && this.organizationId == undefined) {
       this.organizationId = this.defaultOwnerId;
     }
-
-    this.resetMaskState();
   }
 
   async load() {
@@ -274,8 +272,6 @@ export class AddEditComponent implements OnInit, OnDestroy {
         this.cipher.secureNote.type = SecureNoteType.Generic;
         this.cipher.reprompt = CipherRepromptType.None;
       }
-
-      this.resetMaskState();
     }
 
     if (this.cipher != null && (!this.editMode || loadedAddEditCipherInfo || this.cloneMode)) {
@@ -517,12 +513,6 @@ export class AddEditComponent implements OnInit, OnDestroy {
     return true;
   }
 
-  resetMaskState() {
-    // toggle masks off for maskable login properties with no value on init/load
-    this.showTotpSeed = !this.cipher?.login?.totp;
-    this.showPassword = !this.cipher?.login?.password;
-  }
-
   togglePassword() {
     this.showPassword = !this.showPassword;