[PM-4284] Passkey popout is not pulling correct URI for website opened (

#6549) * Used url from sender window in getting matching logins * Rough draft to combine user verification required and master password required prompts * Revert "Rough draft to combine user verification required and master password required prompts" This reverts commit f72d6f8.
bitwarden · Oct 12, 2023 · 973bbc4 · 973bbc4
1 parent 6a9afa8
commit 973bbc4
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 12 deletions.
diff --git a/apps/browser/src/platform/popup/abstractions/browser-popout-window.service.ts b/apps/browser/src/platform/popup/abstractions/browser-popout-window.service.ts
@@ -29,7 +29,7 @@ interface BrowserPopoutWindowService {
   ): Promise<void>;
   closePasswordRepromptPrompt(): Promise<void>;
   openFido2Popout(
-    senderWindowId: number,
+    senderWindow: chrome.tabs.Tab,
     promptData: {
       sessionId: string;
       senderTabId: number;

diff --git a/apps/browser/src/platform/popup/browser-popout-window.service.ts b/apps/browser/src/platform/popup/browser-popout-window.service.ts
@@ -96,7 +96,7 @@ class BrowserPopoutWindowService implements BrowserPopupWindowServiceInterface {
   }
 
   async openFido2Popout(
-    senderWindowId: number,
+    senderWindow: chrome.tabs.Tab,
     {
       sessionId,
       senderTabId,
@@ -114,12 +114,18 @@ class BrowserPopoutWindowService implements BrowserPopupWindowServiceInterface {
       "?uilocation=popout" +
       `&sessionId=${sessionId}` +
       `&fallbackSupported=${fallbackSupported}` +
-      `&senderTabId=${senderTabId}`;
-
-    return await this.openSingleActionPopout(senderWindowId, promptWindowPath, "fido2Popout", {
-      width: 200,
-      height: 500,
-    });
+      `&senderTabId=${senderTabId}` +
+      `&senderUrl=${encodeURIComponent(senderWindow.url)}`;
+
+    return await this.openSingleActionPopout(
+      senderWindow.windowId,
+      promptWindowPath,
+      "fido2Popout",
+      {
+        width: 200,
+        height: 500,
+      }
+    );
   }
 
   async closeFido2Popout(): Promise<void> {

diff --git a/apps/browser/src/vault/fido2/browser-fido2-user-interface.service.ts b/apps/browser/src/vault/fido2/browser-fido2-user-interface.service.ts
@@ -343,7 +343,7 @@ export class BrowserFido2UserInterfaceSession implements Fido2UserInterfaceSessi
       )
     );
 
-    const popoutId = await this.browserPopoutWindowService.openFido2Popout(this.tab.windowId, {
+    const popoutId = await this.browserPopoutWindowService.openFido2Popout(this.tab, {
       sessionId: this.sessionId,
       senderTabId: this.tab.id,
       fallbackSupported: this.fallbackSupported,

diff --git a/apps/browser/src/vault/popup/components/fido2/fido2.component.ts b/apps/browser/src/vault/popup/components/fido2/fido2.component.ts
@@ -89,6 +89,7 @@ export class Fido2Component implements OnInit, OnDestroy {
       map((queryParamMap) => ({
         sessionId: queryParamMap.get("sessionId"),
         senderTabId: queryParamMap.get("senderTabId"),
+        senderUrl: queryParamMap.get("senderUrl"),
       }))
     );
 
@@ -97,7 +98,7 @@ export class Fido2Component implements OnInit, OnDestroy {
         concatMap(async ([queryParams, message]) => {
           this.sessionId = queryParams.sessionId;
           this.senderTabId = queryParams.senderTabId;
-
+          this.url = queryParams.senderUrl;
           // For a 'NewSessionCreatedRequest', abort if it doesn't belong to the current session.
           if (
             message.type === "NewSessionCreatedRequest" &&
@@ -145,8 +146,6 @@ export class Fido2Component implements OnInit, OnDestroy {
       concatMap(async (message) => {
         switch (message.type) {
           case "ConfirmNewCredentialRequest": {
-            const activeTabs = await BrowserApi.getActiveTabs();
-            this.url = activeTabs[0].url;
             const equivalentDomains = this.settingsService.getEquivalentDomains(this.url);
 
             this.ciphers = (await this.cipherService.getAllDecrypted()).filter(