-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Firefox extension stops working after entering search term #699
Comments
How many items are in the vault? Can you also reproduce this in the web vault? |
Thanks for the instant reply! Same thing happens with the web vault. Vault contains approximately 500 items. |
Ok. Sounds like there is some item that is causing this same bug I discovered in Lunr: olivernn/lunr.js#368 Try performing your search query with a preceding For example, |
Looks like you're right, preceding the query with |
Ok, it's definitely the bug I linked above which seems to have issues with wildcards, which are used by default when not doing a |
@tomwassenberg I pushed 1.30.2 which reduces regular searching to only trailing wildcards for now. Can you update and try it to see if the problem with regular searching is resolved? |
It was also pushed to the web vault. |
Yes, 1.30.2 (+ web) fixes the problem with regular searches :) |
Closing this for now. Tracking at olivernn/lunr.js#368 |
After upgrading to v1.30.1, the Firefox extension stops responding after I enter a few characters as a search term.
CPU usage rises dramatically and on one of my machines (Windows, Fx 62.0b17) the addon window doesn't re-appear when clicking on the icon. On Linux (Fx 61.0.1) Firefox locks up entirely and has to be force quit.
I can reproduce the issues on v1.30.0 and v1.30.1 of the Firefox extension.
Tested on Windows 10 with Firefox 62.0b17 and Linux Mint with Firefox 61.0.1.
The text was updated successfully, but these errors were encountered: