Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox extension stops working after entering search term #699

Closed
tomwassenberg opened this issue Aug 17, 2018 · 9 comments
Closed

Firefox extension stops working after entering search term #699

tomwassenberg opened this issue Aug 17, 2018 · 9 comments

Comments

@tomwassenberg
Copy link

After upgrading to v1.30.1, the Firefox extension stops responding after I enter a few characters as a search term.

CPU usage rises dramatically and on one of my machines (Windows, Fx 62.0b17) the addon window doesn't re-appear when clicking on the icon. On Linux (Fx 61.0.1) Firefox locks up entirely and has to be force quit.

I can reproduce the issues on v1.30.0 and v1.30.1 of the Firefox extension.

Tested on Windows 10 with Firefox 62.0b17 and Linux Mint with Firefox 61.0.1.

@kspearrin
Copy link
Member

How many items are in the vault? Can you also reproduce this in the web vault?

@tomwassenberg
Copy link
Author

Thanks for the instant reply!

Same thing happens with the web vault. Vault contains approximately 500 items.

@kspearrin
Copy link
Member

Ok. Sounds like there is some item that is causing this same bug I discovered in Lunr: olivernn/lunr.js#368

Try performing your search query with a preceding > and see if the same issue occurs.

For example, >something instead of something.

@tomwassenberg
Copy link
Author

Looks like you're right, preceding the query with > seems to resolve the issue.

@kspearrin
Copy link
Member

Ok, it's definitely the bug I linked above which seems to have issues with wildcards, which are used by default when not doing a > search. Would you happen to have a few minutes to help me try to debug this further in your vault? I am available in our dev chatroom here and would like to try to run through some steps to figure out which item in your vault is causing the problem.

@kspearrin
Copy link
Member

@tomwassenberg I pushed 1.30.2 which reduces regular searching to only trailing wildcards for now. Can you update and try it to see if the problem with regular searching is resolved?

@kspearrin
Copy link
Member

It was also pushed to the web vault.

@tomwassenberg
Copy link
Author

Yes, 1.30.2 (+ web) fixes the problem with regular searches :)

@kspearrin
Copy link
Member

Closing this for now. Tracking at olivernn/lunr.js#368

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants