Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-7646][PM-5506] Revert IPC changes #10946

Merged
merged 4 commits into from
Sep 9, 2024

Conversation

trmartin4
Copy link
Member

@trmartin4 trmartin4 commented Sep 8, 2024

🎟️ Tracking

bitwarden.atlassian.net/browse/PM-7846
bitwarden.atlassian.net/browse/PM-5506

📔 Objective

Reverts the following commits to undo all the new changes for Rust IPC, as we encountered issues in QA and need to revert from main.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@trmartin4 trmartin4 changed the title Platform/pm-7646/revert-all-ipc-changes [PM-7646][PM-5506] Reverted IPC changes Sep 8, 2024
@trmartin4 trmartin4 marked this pull request as ready for review September 8, 2024 21:08
@trmartin4 trmartin4 requested review from a team as code owners September 8, 2024 21:08
@trmartin4 trmartin4 changed the title [PM-7646][PM-5506] Reverted IPC changes [PM-7646][PM-5506] Revert IPC changes Sep 8, 2024
Copy link

codecov bot commented Sep 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 127 lines in your changes missing coverage. Please review.

Project coverage is 33.07%. Comparing base (ee738ac) to head (cd7b924).
Report is 3 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/desktop/src/proxy/ipc.ts 0.00% 38 Missing ⚠️
apps/desktop/src/main/native-messaging.main.ts 0.00% 34 Missing ⚠️
apps/desktop/src/proxy/nativemessage.ts 0.00% 34 Missing ⚠️
apps/desktop/src/entry.ts 0.00% 10 Missing ⚠️
apps/desktop/src/proxy/native-messaging-proxy.ts 0.00% 8 Missing ⚠️
apps/desktop/src/main.ts 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10946      +/-   ##
==========================================
- Coverage   33.11%   33.07%   -0.05%     
==========================================
  Files        2680     2683       +3     
  Lines       83447    83528      +81     
  Branches    15869    15872       +3     
==========================================
- Hits        27635    27628       -7     
- Misses      53633    53721      +88     
  Partials     2179     2179              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

github-actions bot commented Sep 8, 2024

Logo
Checkmarx One – Scan Summary & Details1ca25f68-be58-48dc-927d-1ef67e65b0d1

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1245 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1291 Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity Issue Source File / Package
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1256
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 1302
MEDIUM Unpinned Actions Full Length Commit SHA /build-desktop.yml: 288

@trmartin4 trmartin4 merged commit ed4d481 into main Sep 9, 2024
69 checks passed
@trmartin4 trmartin4 deleted the platform/pm-7646/revert-all-ipc-changes branch September 9, 2024 13:09
dani-garcia added a commit that referenced this pull request Sep 18, 2024
dani-garcia added a commit that referenced this pull request Oct 1, 2024
* Revert "[PM-7646][PM-5506] Revert IPC changes (#10946)"

This reverts commit ed4d481.

* Ensure tmp dir gets created on MacOS

* Remove client reconnections

* Improve client error handling and process exiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants