[PM-11899] - send text details component #11002

jaasen-livefront · 2024-09-11T22:16:35Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-11899

📔 Objective

This PR adds the send text details component with a corresponding send details and base send component to allow shared use of the logic and structure for the upcoming send file details component. This is one of three PRs for the new create send UI as part of the extension refresh. Credit goes to @djsmith85 for helping set this up.

📸 Screenshots

New	Edit

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov · 2024-09-11T22:25:06Z

Codecov Report

Attention: Patch coverage is 0% with 86 lines in your changes missing coverage. Please review.

Please upload report for BASE (main@1b7bb01). Learn more about missing BASE report.
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...onents/send-details/base-send-details.component.ts	0.00%	41 Missing ⚠️
...onents/send-details/send-text-details.component.ts	0.00%	21 Missing ⚠️
.../components/send-details/send-details.component.ts	0.00%	19 Missing ⚠️
...ibs/common/src/tools/send/services/send.service.ts	0.00%	2 Missing ⚠️
...ui/src/send-form/components/send-form.component.ts	0.00%	2 Missing ⚠️
...rc/send-form/services/default-send-form.service.ts	0.00%	1 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #11002   +/-   ##
=======================================
  Coverage        ?   34.96%           
=======================================
  Files           ?     2701           
  Lines           ?    84282           
  Branches        ?    16016           
=======================================
  Hits            ?    29472           
  Misses          ?    53841           
  Partials        ?      969

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-actions · 2024-09-12T00:46:40Z

Checkmarx One – Scan Summary & Details – a01aa053-1444-412c-ac8e-6eeed72177bb

No New Or Fixed Issues Found

djsmith85

Only a partial review

As discussed I'm uncertain about the changes to the send and sendApi services, which we should likely revert and focus this PR on the UI changes. If it breaks saving Sends on the feature-flagged part, we should fix it in a separate PR.

djsmith85 · 2024-09-17T16:02:30Z

libs/angular/src/utils/extension-refresh-swap.ts

@@ -23,6 +23,7 @@ export function extensionRefreshSwap(
    defaultComponent,
    refreshedComponent,
    async () => {
+      return true;


⚠️ Please remove this. This was only added it for easier development, but should never be merged.

djsmith85 · 2024-09-17T16:06:26Z

libs/common/src/tools/send/models/view/send.view.ts

@@ -26,6 +26,7 @@ export class SendView implements View {
  password: string = null;
  disabled = false;
  hideEmail = false;
+  hideText = false;


⚠️ Did this get added by mistake and you wanted to use SendView.text.hidden instead, as done within the component?

jaasen-livefront · 2024-09-17T20:48:58Z

Only a partial review

As discussed I'm uncertain about the changes to the send and sendApi services, which we should likely revert and focus this PR on the UI changes. If it breaks saving Sends on the feature-flagged part, we should fix it in a separate PR.

Sounds good. The type changes were only a narrowing of types so reverting back to any won't cause any issues.

This reverts commit 36711d5.

…1899

djsmith85 · 2024-09-18T11:47:51Z

apps/browser/src/_locales/en/messages.json

+  "textHiddenByDefault": {
+    "message": "When accessing the Send, hide the text by default",
+    "description": "'Send' is a noun and the name of a feature called 'Bitwarden Send'. It should not be translated."
+  },


⚠️ Message key is not used anywhere and is duplicated by hideTextByDefault which is used.

Addressed with efffcc6

djsmith85 · 2024-09-18T11:48:48Z

apps/browser/src/_locales/en/messages.json

+  "limitSendViews": {
+    "message": "Limit views"
+  },
+  "limitSendViewsHint": {
+    "message": "No one can view this Send after the limit is reached.",
+    "description": "Displayed under the limit views field on Send"
+  },
+  "limitSendViewsHintWithCount": {
+    "message": "No one can view this Send after the limit is reached. $ACCESSCOUNT$ views left",
+    "description": "Displayed under the limit views field on Send",
+    "placeholders": {
+      "accessCount": {
+        "content": "$1",
+        "example": "2"
+      }
+    }
+  },


⚠️ These message keys are not used anywhere. Need to be removed. Likely will be introduced with the send-options component

Addressed with efffcc6

djsmith85 · 2024-09-18T11:49:49Z

libs/tools/send/send-ui/src/send-form/components/send-details/send-text-details.component.html

+  <bit-form-field>
+    <bit-label>{{ "sendTypeTextToShare" | i18n }}</bit-label>
+    <textarea bitInput id="text" rows="6" formControlName="text"></textarea>
+    <bit-hint>{{ "sendTextDesc" | i18n }}</bit-hint>


⚠️ The hint is not included within the latest design.

Addressed with 6c7ad7c

djsmith85

@jaasen-livefront Addressed some minor issues myself and this is now ready to merge.

djsmith85 and others added 4 commits September 11, 2024 13:59

Temporary local changes not meant to be merged

6052698

WIP - send text details

3a0ec5c

send text details

df4dc00

remove extraneous code

5733531

jaasen-livefront requested a review from a team as a code owner September 11, 2024 22:16

jaasen-livefront requested a review from djsmith85 September 11, 2024 22:16

jaasen-livefront added 2 commits September 11, 2024 17:43

create base send details component

d4c149a

remove file components

3b968c0

jaasen-livefront added 3 commits September 12, 2024 13:50

fix send text details form

83587ca

remove comments

f1ee108

fix send text details component

d516c30

djsmith85 requested changes Sep 17, 2024

View reviewed changes

revert type changes

a151f40

jaasen-livefront requested a review from djsmith85 September 17, 2024 20:48

jaasen-livefront and others added 3 commits September 17, 2024 16:30

send created redirect

36711d5

Revert "send created redirect"

c585534

This reverts commit 36711d5.

Merge branch 'main' of https://github.com/bitwarden/clients into PM-1…

6f25656

…1899

djsmith85 requested changes Sep 18, 2024

View reviewed changes

djsmith85 added 2 commits September 18, 2024 13:50

Removed hint under textArea, as per design

6c7ad7c

Removed unused message keys

efffcc6

djsmith85 approved these changes Sep 18, 2024

View reviewed changes

djsmith85 merged commit f8fc626 into main Sep 18, 2024
60 of 62 checks passed

djsmith85 deleted the PM-11899 branch September 18, 2024 12:04

djsmith85 mentioned this pull request Sep 18, 2024

Fix click on copy send link and delete send buttons #11120

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-11899] - send text details component #11002

[PM-11899] - send text details component #11002

jaasen-livefront commented Sep 11, 2024 •

edited

Loading

codecov bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

djsmith85 left a comment

djsmith85 Sep 17, 2024

djsmith85 Sep 17, 2024

jaasen-livefront commented Sep 17, 2024 •

edited

Loading

djsmith85 Sep 18, 2024

djsmith85 Sep 18, 2024

djsmith85 Sep 18, 2024

djsmith85 Sep 18, 2024

djsmith85 Sep 18, 2024

djsmith85 Sep 18, 2024

djsmith85 left a comment

[PM-11899] - send text details component #11002

[PM-11899] - send text details component #11002

Conversation

jaasen-livefront commented Sep 11, 2024 • edited Loading

🎟️ Tracking

📔 Objective

📸 Screenshots

⏰ Reminders before review

🦮 Reviewer guidelines

codecov bot commented Sep 11, 2024 • edited Loading

Codecov Report

github-actions bot commented Sep 12, 2024 • edited Loading

No New Or Fixed Issues Found

djsmith85 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jaasen-livefront commented Sep 17, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

djsmith85 left a comment

Choose a reason for hiding this comment

jaasen-livefront commented Sep 11, 2024 •

edited

Loading

codecov bot commented Sep 11, 2024 •

edited

Loading

github-actions bot commented Sep 12, 2024 •

edited

Loading

jaasen-livefront commented Sep 17, 2024 •

edited

Loading