Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete SendForm storybook stories #11149

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

djsmith85
Copy link
Contributor

📔 Objective

Remove un-used/maintained storybook stories for the SendForm. They don't seem as useful as the CipherForm these stories are based on.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@djsmith85 djsmith85 requested a review from a team as a code owner September 19, 2024 11:06
@djsmith85 djsmith85 enabled auto-merge (squash) September 19, 2024 11:08
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 35.08%. Comparing base (6484460) to head (dc382d8).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11149   +/-   ##
=======================================
  Coverage   35.07%   35.08%           
=======================================
  Files        2710     2709    -1     
  Lines       84542    84521   -21     
  Branches    16064    16064           
=======================================
  Hits        29653    29653           
+ Misses      53918    53897   -21     
  Partials      971      971           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

Logo
Checkmarx One – Scan Summary & Details13b813e6-2e68-4e4b-9731-bba879a83a36

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /libs/importer/src/services/import.service.ts: 455

@djsmith85 djsmith85 merged commit 7f9c5ce into main Sep 19, 2024
64 of 65 checks passed
@djsmith85 djsmith85 deleted the tools/pm-xxx/delete-send-form-storybook-stories branch September 19, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants