Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PM-12721]- disable copy button if no password is present #11349

Merged
merged 1 commit into from
Oct 1, 2024
Merged

Conversation

jaasen-livefront
Copy link
Collaborator

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-12721

📔 Objective

This PR disables the copy password button when the password input is blank.

📸 Screenshots

Screen.Recording.2024-10-01.at.1.20.06.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 33.25%. Comparing base (9ff1db7) to head (87e9208).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11349      +/-   ##
==========================================
- Coverage   33.25%   33.25%   -0.01%     
==========================================
  Files        2732     2732              
  Lines       85545    85545              
  Branches    16304    16304              
==========================================
- Hits        28451    28444       -7     
- Misses      54838    54845       +7     
  Partials     2256     2256              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jaasen-livefront jaasen-livefront changed the title disable copy button if no password is present [PM-12721]- disable copy button if no password is present Oct 1, 2024
Copy link
Contributor

github-actions bot commented Oct 1, 2024

Logo
Checkmarx One – Scan Summary & Details0e2cdb81-9ea1-4a73-8644-0089c849d0d4

No New Or Fixed Issues Found

@djsmith85 djsmith85 merged commit 97a97c4 into main Oct 1, 2024
65 checks passed
@djsmith85 djsmith85 deleted the PM-12721-2 branch October 1, 2024 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants