[PM-9693] Refresh - LoginDecryptionOptionsComponent #11782

rr-bw · 2024-10-29T20:22:15Z

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-9693

📔 Objective

Creates a refreshed and consolidated LoginDecryptionOptionsComponent for use on all visual clients, which will be used when the UnauthenticatedExtensionUIRefresh is on.

Notes

c4fa333 - Use takeUntilDestroyed(this.destroyRef) in non-injection context (Contributing Docs > Code Style > Angular & TypeScript)

📸 Screenshots

Web - Admin Approval

admin-approval.mov

Web - Approve with MP

approve-with-master-password.mov

Web - Approve from other device

approve-from-other-device.mov

Web - New User

new-user.mov

Desktop - Admin Approval

desktop-admin-approval.mov

Browser - Admin Approval

extension-admin-approval.mov

⏰ Reminders before review

Contributor guidelines followed
All formatters and local linters executed and passed
Written new unit and / or integration tests where applicable
Protected functional changes with optionality (feature flags)
Used internationalization (i18n) for all UI strings
CI builds passed
Communicated to DevOps any deployment requirements
Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

👍 (:+1:) or similar for great changes
📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
❓ (:question:) for questions
🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
🎨 (:art:) for suggestions / improvements
❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
⛏ (:pick:) for minor or nitpick changes

codecov · 2024-10-29T20:32:19Z

Codecov Report

Attention: Patch coverage is 7.09677% with 144 lines in your changes missing coverage. Please review.

Project coverage is 33.43%. Comparing base (3a293bb) to head (df815b1).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...tion-options/login-decryption-options.component.ts	0.00%	122 Missing ⚠️
libs/auth/src/angular/index.ts	0.00%	3 Missing ⚠️
...n-options/login-decryption-options-v1.component.ts	0.00%	2 Missing ⚠️
...n-options/login-decryption-options-v1.component.ts	0.00%	2 Missing ⚠️
...n-options/login-decryption-options-v1.component.ts	0.00%	2 Missing ⚠️
libs/auth/src/angular/icons/devices.icon.ts	0.00%	2 Missing ⚠️
apps/browser/src/popup/app-routing.module.ts	0.00%	1 Missing ⚠️
apps/browser/src/popup/app.module.ts	0.00%	1 Missing ⚠️
apps/desktop/src/app/app-routing.module.ts	0.00%	1 Missing ⚠️
apps/desktop/src/auth/login/login.module.ts	0.00%	1 Missing ⚠️
... and 7 more

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #11782      +/-   ##
==========================================
- Coverage   33.47%   33.43%   -0.04%     
==========================================
  Files        2844     2850       +6     
  Lines       89044    89186     +142     
  Branches    16987    17019      +32     
==========================================
+ Hits        29805    29823      +18     
- Misses      56894    57018     +124     
  Partials     2345     2345

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…s-component

…igation

…s-component

github-actions · 2024-11-07T21:07:39Z

Checkmarx One – Scan Summary & Details – ae514b5f-0055-484a-958c-b5e1fcf24c57

New Issues

Issue	Source File / Package	Checkmarx Insight
Unpinned Actions Full Length Commit SHA	/build-web.yml: 204	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-web.yml: 283	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 318	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-browser.yml: 416	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 40	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-web.yml: 362	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1391	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-browser.yml: 372	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 928	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-web.yml: 314	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1342	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...
Unpinned Actions Full Length Commit SHA	/build-cli.yml: 421	Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps...

Fixed Issues

Severity	Issue	Source File / Package
	Client_JQuery_Deprecated_Symbols	/apps/cli/src/service-container/service-container.ts: 876
	Client_JQuery_Deprecated_Symbols	/libs/importer/src/services/import.service.ts: 467
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1012
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1456
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 665
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 342
	Unpinned Actions Full Length Commit SHA	/build-web.yml: 133
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1505
	Unpinned Actions Full Length Commit SHA	/build-web.yml: 338
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 121
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 357
	Unpinned Actions Full Length Commit SHA	/build-browser.yml: 184
	Unpinned Actions Full Length Commit SHA	/build-web.yml: 386
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1356
	Unpinned Actions Full Length Commit SHA	/build-web.yml: 307
	Unpinned Actions Full Length Commit SHA	/build-web.yml: 228
	Unpinned Actions Full Length Commit SHA	/build-browser.yml: 478
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 853
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 1101
	Unpinned Actions Full Length Commit SHA	/build-browser.yml: 379
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 276
	Unpinned Actions Full Length Commit SHA	/crowdin-pull.yml: 47
	Unpinned Actions Full Length Commit SHA	/build-browser.yml: 434
	Unpinned Actions Full Length Commit SHA	/build-cli.yml: 465
	Unpinned Actions Full Length Commit SHA	/build-desktop.yml: 191

dani-garcia

Platform changes LGTM

…s-component

rr-bw added 2 commits October 29, 2024 12:46

rename legacy components to v1

d0bc2b9

setup new component and routes

f453cc8

rr-bw added 23 commits October 29, 2024 14:25

add template

d8927de

Merge branch 'main' into auth/pm-9693/refresh-login-decryption-option…

69a9671

…s-component

setup rememberDevice control methods

32148cf

use takeUntilDestroyed(this.destroyRef)

c4fa333

migrate loadUntrustedDeviceData() and requestAdminApproval() methods

335958e

migrate approveFromOtherDevice() method

d5660a9

migrate approveWithMasterPassword() method

a2c3735

migrate loadNewUserData() and restructure template

6aa416e

setup services

b7b613b

migrate and refactor createUser() method

869add9

remove comment

7f0ff35

refactor email usage and loading state

ab66de1

refactor UI data properties

eea4aac

refactor properties

3e66a05

Merge branch 'main' into auth/pm-9693/refresh-login-decryption-option…

236210c

…s-component

small reformatting and cleanup

ff7fbc7

Merge branch 'main' into auth/pm-9693/refresh-login-decryption-option…

44dd2e8

…s-component

add tests

0ff5104

extract functions - handleMissingEmail and handleCreateUserSuccessNav…

f72c2a0

…igation

update AnonLayout properties via AnonLayoutWrapperDataService

ac97fae

Merge branch 'main' into auth/pm-9693/refresh-login-decryption-option…

8ff004a

…s-component

add devices icon

14ffc1f

remove TODO comments

c1a6655

update logic for when the 'or' text is shown

e94bffd

rr-bw marked this pull request as ready for review November 7, 2024 23:31

rr-bw requested a review from a team as a code owner November 7, 2024 23:31

rr-bw requested review from dani-garcia and ike-kottlowski November 7, 2024 23:31

dani-garcia previously approved these changes Nov 8, 2024

View reviewed changes

ike-kottlowski previously approved these changes Nov 8, 2024

View reviewed changes

withinfocus and others added 3 commits November 11, 2024 17:47

Merge branch 'main' into auth/pm-9693/refresh-login-decryption-option…

430d684

…s-component

Merge branch 'main' into auth/pm-9693/refresh-login-decryption-option…

df815b1

…s-component

better handling of missing email case

aab0f60

rr-bw dismissed stale reviews from dani-garcia and ike-kottlowski via aab0f60 November 19, 2024 21:30

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[PM-9693] Refresh - LoginDecryptionOptionsComponent #11782

[PM-9693] Refresh - LoginDecryptionOptionsComponent #11782

rr-bw commented Oct 29, 2024 •

edited

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading

dani-garcia left a comment

[PM-9693] Refresh - LoginDecryptionOptionsComponent #11782

Are you sure you want to change the base?

[PM-9693] Refresh - LoginDecryptionOptionsComponent #11782

Conversation

rr-bw commented Oct 29, 2024 • edited Loading

🎟️ Tracking

📔 Objective

📸 Screenshots

Web - Admin Approval

Web - Approve with MP

Web - Approve from other device

Web - New User

Desktop - Admin Approval

Browser - Admin Approval

⏰ Reminders before review

🦮 Reviewer guidelines

codecov bot commented Oct 29, 2024 • edited Loading

Codecov Report

github-actions bot commented Nov 7, 2024 • edited Loading

New Issues

Fixed Issues

dani-garcia left a comment

Choose a reason for hiding this comment

rr-bw commented Oct 29, 2024 •

edited

Loading

codecov bot commented Oct 29, 2024 •

edited

Loading

github-actions bot commented Nov 7, 2024 •

edited

Loading