[PM-15065] Vault Loading on empty tabs

[nick-livefront]

🎟️ Tracking

PM-15065
Slack Discussion

📔 Objective

When on a non-standard page or empty tab is focused when opening the extension, the vault was taking longer than expected to load. This was caused from a message never being received in the collectPageDetailsFromTab$ observable.

• The underlying sendMessage fails in Chrome and Firefox. That error was ignored in the tabSendMessage, I now rejected the promise to surface the error.
• Safari does not throw an error but a new tab does not have a url, I added a check for that as there wouldn't be autofill information (to my knowledge)

Rejecting the promise

This approach falls in line with what is happening but it is also introducing a new set of logic where tabSendMessage is called. Scanning the codebase there are places that have error handling and some that do not. If there is a more idiomatic approach, let me know!

📸 Screenshots

Chrome	FireFox	Safari
chrome-after.mov	firefox-after.mov	safari-after.mov

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov]

Codecov Report

Attention: Patch coverage is 88.88889% with 1 line in your changes missing coverage. Please review.

Project coverage is 33.52%. Comparing base (2df8643) to head (963000f).

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
apps/browser/src/platform/browser/browser-api.ts	50.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #12059      +/-   ##
==========================================
- Coverage   33.52%   33.52%   -0.01%     
==========================================
  Files        2859     2859              
  Lines       89434    89438       +4     
  Branches    17022    17023       +1     
==========================================
- Hits        29986    29983       -3     
- Misses      57087    57094       +7     
  Partials     2361     2361              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

---

🚨 Try these New Features:

• JS Bundle Analysis - Avoid shipping oversized bundles

[github-actions]

Checkmarx One – Scan Summary & Details – 43062958-dc1d-4f5f-aa05-5d2bf1052f95

No New Or Fixed Issues Found