[PM-15937] ssh agent: fix first start when no .bitwarden-ssh-agent.sock exists

[Icelk]

🎟️ Tracking

#10825

📔 Objective

When starting the ssh-agent the first time on unix, the rust code tries to remove the previous ssh-agent socket. On first time setup, there is no file, so it fails. This change makes it fail gracefully when no file is found.

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[CLAassistant]

All committers have signed the CLA.

[bitwarden-bot]

Thank you for your contribution! We've added this to our internal Community PR board for review.
ID: PM-15937
Link: https://bitwarden.atlassian.net/browse/PM-15937

Details on our contribution process can be found here: https://contributing.bitwarden.com/contributing/pull-requests/community-pr-process.

[quexten]

Ohh, interesting. I think this error was introduced as a result of a last minute security fix (#12048).

I will test the PR closely tomorrow and give the final approval. Thank you for the PR!

[quexten]

Changes look good, I've reproduced the bug and confirmed this fixes it. Thank you!

[quexten]

@Icelk Could you accept the CLA? (If you've already done that, also let me know. I know the CLAssistant was buggy the past few weeks).

[github-actions]

Checkmarx One – Scan Summary & Details – 80a55b62-cf38-4286-aa1d-cc1e8526e0f6

No New Or Fixed Issues Found

[Icelk]

Could you accept the CLA? (If you've already done that, also let me know. I know the CLAssistant was buggy the past few weeks).

Just did, thanks for reminding me :)

And also thank you for developing Bitwarden and all it's components! It's a great project and hugely appreciated.

[quexten]

Nice, thanks again for the PR!