Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PS-124] Update so the image for the clear search button is visible in all themes #2639

Merged
merged 5 commits into from
May 16, 2022
Merged

[PS-124] Update so the image for the clear search button is visible in all themes #2639

merged 5 commits into from
May 16, 2022

Conversation

CarleyDiaz-Bitwarden-zz
Copy link
Contributor

@CarleyDiaz-Bitwarden-zz CarleyDiaz-Bitwarden-zz commented May 5, 2022 •
edited by MGibson1
Loading

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

Ensure clear search button is always visible in all themes

Code changes

new white close "x" svg added
code to overwrite current x image with a themed color svg

Screenshots

Screen Shot 2022-05-02 at 12 08 16 PM
Screen Shot 2022-05-02 at 12 08 54 PM

Testing requirements

View the search header clear/close button and make sure it's visible in all three themes

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@djsmith85 djsmith85 requested a review from Hinton May 6, 2022 09:36
Hinton
Hinton previously approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@Hinton Hinton left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Linting is solved in #2643

@djsmith85 djsmith85 changed the title Update so the image for the clear search button is visible in all themes [PS-124] Update so the image for the clear search button is visible in all themes May 6, 2022
@djsmith85 djsmith85 linked an issue May 7, 2022 that may be closed by this pull request
Desktop: The "clear" symbol (x) is hardly visible in the search bar #2570
Closed
Hinton
Hinton approved these changes May 10, 2022
View reviewed changes
Copy link
Member

@Hinton Hinton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great!

@CarleyDiaz-Bitwarden-zz CarleyDiaz-Bitwarden-zz merged commit f66129e into master May 16, 2022
@patrickhlauke
Copy link
Contributor

nicely done

@djsmith85 djsmith85 mentioned this pull request Aug 16, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Hinton Hinton Hinton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Desktop: The "clear" symbol (x) is hardly visible in the search bar
3 participants
@CarleyDiaz-Bitwarden-zz @patrickhlauke @Hinton