Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PS-1387] Desktop: Remove "delete account" from settings #3406

Merged
merged 7 commits into from
Sep 9, 2022
Merged

[PS-1387] Desktop: Remove "delete account" from settings #3406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
19c15c8
Make "delete account" control an actual button
patrickhlauke Aug 28, 2022
ca18813
Remove "Delete Account" section from desktop settings altogether
patrickhlauke Aug 29, 2022
92d22f3
Merge branch 'master' into patrickhlauke-issue3401
patrickhlauke Aug 29, 2022
274245b
Merge branch 'master' into patrickhlauke-issue3401
patrickhlauke Sep 4, 2022
366b489
Merge branch 'master' into patrickhlauke-issue3401
patrickhlauke Sep 5, 2022
8bac4a9
Remove `openDeleteAccount` and `DeleteAccountComponent` import
patrickhlauke Sep 5, 2022
d042e9e
Merge branch 'patrickhlauke-issue3401' of https://github.com/patrickh…
patrickhlauke Sep 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 0 additions & 8 deletions apps/desktop/src/app/accounts/settings.component.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,14 +108,6 @@ <h2>
</label>
</div>
</div>

<div class="form-group">
<label>{{ "deleteAccount" | i18n }}</label>
<small class="help-block">
{{ "deleteAccountDesc" | i18n }}
<a (click)="openDeleteAccount()">{{ "deleteAccount" | i18n }}</a>
</small>
</div>
</ng-container>
</div>
</div>
Expand Down
6 changes: 0 additions & 6 deletions apps/desktop/src/app/accounts/settings.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,8 +18,6 @@ import { isWindowsStore } from "@bitwarden/electron/utils";

import { SetPinComponent } from "../components/set-pin.component";

import { DeleteAccountComponent } from "./delete-account.component";

@Component({
selector: "app-settings",
templateUrl: "settings.component.html",
Expand Down Expand Up @@ -439,8 +437,4 @@ export class SettingsComponent implements OnInit {
this.enableBrowserIntegrationFingerprint
);
}

async openDeleteAccount() {
this.modalService.open(DeleteAccountComponent, { replaceTopModal: true });
}
}