-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PS-1388] Desktop, browser, web: Don't prevent whitespace wrapping in links/buttons, widen desktop pages #3407
[PS-1388] Desktop, browser, web: Don't prevent whitespace wrapping in links/buttons, widen desktop pages #3407
Conversation
Allowing whitespace to wrap solves the issue of long link/button text awkwardly breaking out of controls Widening desktop "pages" prevents some unnecessary wrapping in places like the "Create account" button on the login screen, whose content is slightly wider than it should be (but this is currently masked by the `nowrap`) Closes bitwarden#2620
Thank you for your contribution! We've added this to our internal Community PR board for review. |
/cc @danielleflinn as this affects layout/UI |
Just noticed #2714 which tries to tackle the issue from the other end (setting |
Thanks Patrick! We recently created a new Github team for design changes. If you can use @bitwarden/dept-design in future PRs that affect UI that would be much appreciated. As always, thank you for your contribution! |
@danielleflinn sure thing! |
@danielleflinn https://github.com/orgs/bitwarden/teams/dept-design 404s for me, and when I try to manually @bitwarden/dept-design it doesn't seem to recognise it ... is it publicly accessible? |
Oh you are right; looks like only Github organization members can tag a team. Feel free to ignore the previous comment then. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is looking good. @patrickhlauke Thank you for your contributions.
Type of change
Objective
Allowing whitespace to wrap solves the issue of long link/button text awkwardly breaking out of controls
Widening desktop "pages" prevents some unnecessary wrapping in places like the "Create account" button on the login screen, whose content is slightly wider than it should be (but this is currently masked by the
nowrap
)Closes #2620
Code changes
white-space: nowrap
from the various button/link styles, allowing overly-long content to wrap rather than break out300px
to325px
(admittedly, this makes them go out of sync with small modals?)Screenshots
Before (taken from #2620):
After:
I had a look around the desktop, web, and popup versions with this change applied, and did not come across any other changes/adverse effects - though recommend giving them a thorough once-over, just in case some situation/screen did rely on the
nowrap
Before you submit